Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery provision changes #2435

Merged

Conversation

abhishek-sa1
Copy link
Collaborator

@abhishek-sa1 abhishek-sa1 commented Feb 3, 2025

  • Discovery provision changes
  • Lint fixes
  • Updating ansible.cfg

@priti-parate @Aditya-DP @suman-square @Kratika-P @nethramg @Milisha-Gupta

@abhishek-sa1 abhishek-sa1 marked this pull request as ready for review February 3, 2025 12:32
@@ -29,7 +29,7 @@
tasks:
- name: Decrypt provision_credentials_config.yml
ansible.builtin.include_role:
name: discovery_validations/common
name: discovery_validations/common # noqa: role-name[path]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add thin in skip_list instead of here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In public GitHub ansible lint not integrated yet. Lint will throw error till then. After integration by adding skip_list we can remove all this references.

@priti-parate priti-parate merged commit 11f16c1 into dell:pub/new_architecture Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants