Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple update resource migration to Terraform Plugin Framework #112

Merged
merged 13 commits into from
Oct 30, 2023

Conversation

rounak-adhikary
Copy link
Collaborator

@rounak-adhikary rounak-adhikary commented Oct 26, 2023

  • Migrated simple_update to tpf framework
  • simple_update is now action based, it will be recreated for anything substantial. The update operation is dummy.
  • Relaxed cyclometric complexity from 10 to 20. It was giving error for PowerOperation and updateRedfishSimpleUpdate methods, which, IMHO, isn't too complex.
  • Added in golanci-lint the skipping of unmigrated files inside redfish folder as the report seemed too cluttered. The expectation is that whenever new files from that directory is migrated, the developer re-enables linting for those files.
    Removed user and virtual media entries to avoid confusion.

Coverage report:

image

@terraform-providers-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@rounak-adhikary rounak-adhikary changed the base branch from main to dev October 26, 2023 04:57
.golangci.yaml Outdated Show resolved Hide resolved
@Krishnan-Priyanshu Krishnan-Priyanshu merged commit 6d7873c into dev Oct 30, 2023
4 of 5 checks passed
@rounak-adhikary rounak-adhikary deleted the su-res branch March 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants