Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HDFS dependencies #689

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update HDFS dependencies #689

wants to merge 2 commits into from

Conversation

rzepinskip
Copy link

@rzepinskip rzepinskip commented Feb 11, 2025

What changes are proposed in this pull request?

Updates HDFS dependencies to newest versions according to compatibility matrix.

How was this change tested?

I expect current CI pipeline to cover this since there is a HDFS integration test. Also, I have run tests successfully (apart from code coverage due to missing CI secret) on my fork.

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Feb 11, 2025
@@ -39,6 +39,6 @@ arrow-select = { version = ">=53, <55" }
arrow-schema = { version = ">=53, <55" }
parquet = { version = ">=53, <55", features = ["object_store"] }
object_store = { version = ">=0.11, <0.12" }
hdfs-native-object-store = "0.12.0"
hdfs-native = "0.10.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rzepinskip, thanks for your contribution!

I may be missing something, but doesn't the compatibility matrix state that hdfs-native=0.11 is only compatible with hdfs-native-obiject-store=0.13.x?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I had 0.13.0 there before but I found out it is not released yet and changed to 0.12.1. I raised a question in hdfs-native-object-store repo to clarify confusion.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They forgot to publish 0.13.0. It was published just now so I updated the PR accordingly.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (eedfd47) to head (c80d664).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files          77       77           
  Lines       17805    17805           
  Branches    17805    17805           
=======================================
  Hits        14973    14973           
  Misses       2117     2117           
  Partials      715      715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roeap roeap requested a review from OussamaSaoudi February 15, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require a version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants