add accessibility label for ••• #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we use "•••" to indicate "other" reactions visually, however, when visually impaired, eg. screen readers won't have a clue. therefore, set accessibilityLabel to "Other". for the other reactions, things might be good enough, at least, voice over has a chance to read this out in its meaning. if we get concrete feedback, we'll try to improve.
r10s
force-pushed
the
r10s/react-other-accessibility
branch
from
1d8deb5 to
47b4a23
Compare
adbenitez
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review is best done with ignoring whitespace, this PR adds a few lines only.
we use "•••" to indicate "other" reactions visually, however, when visually impaired, eg. screen readers won't have a clue.
therefore, set accessibilityLabel to "Other".
for the other reactions, things might be good enough, at least, voice over has a chance to read this out in its meaning. if we get concrete feedback, we'll try to improve.