add profile on tap/scan QR code unconditionally #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when tap/scan QR code after hitting "Add Profile", things are fine, a new profile was added explictly. however, when tap/scan QR code when a profile is just opened normally (in chatlist or chat), we need to add an account and not use the existing one. (we cannot just always create an account when entering the viewController as we want things as name and avatar being persisted when switching shortly to the browser to select another chatmail server) counterpart of deltachat/deltachat-android#3112
adbenitez
approved these changes
Jun 2, 2024
…(there is another confirmation later, but that is already on another screen and ppl may be wondering how to go back)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when tap/scan QR code after hitting "Add Profile", things are fine, a new profile was added explictly.
however, when tap/scan QR code when a profile is just opened normally (in chatlist or chat),
we need to add an account and not use the existing one.
(we cannot just always create an account when entering the viewController as we want things as name and avatar being persisted when switching shortly to the browser to select another chatmail server)
counterpart of deltachat/deltachat-android#3112