Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search to send-contact-list (#2209) #2218

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

zeitschlag
Copy link
Collaborator

@zeitschlag zeitschlag commented Jun 21, 2024

Steals some of stuff from GroupMemberViewController, but I don't think a new component makes a lot of sense here.
It uses the Core(tm) for search and to the user it looks like this:

2209

Closes #2209.

@zeitschlag zeitschlag self-assigned this Jun 21, 2024
@zeitschlag zeitschlag marked this pull request as ready for review June 21, 2024 13:43
@zeitschlag zeitschlag requested a review from r10s June 21, 2024 13:43
@r10s
Copy link
Member

r10s commented Jun 24, 2024

two bugs i encountered during testing:

  • when searching for a contact and tapping the result, not the tapped result is staged as vcard - but sth. else (maybe the contact at the given position without search)
  • sometimes, the input bar with the staged vcard is not shown - it is still staged (so if you leave and re-enter the chat, you see the staged vcard)
    this happens every few times for me on iphone13 (i also have video with lots of personal data, however, can send that in private if needed)
    Moved to InputBar-Issues in ChatViewController #2221

apart from that, UI looks nice and how one would expect it 👌

@zeitschlag zeitschlag merged commit b3412ff into main Jun 27, 2024
1 check passed
@zeitschlag zeitschlag deleted the 2209-search-contacts branch June 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Search to "Send Contact"-screen
2 participants