add option to 'mark all selected chats read' #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/mark-selection-read
branch
from
059079c to
8977b78
Compare
this adds an option to mark selected chats as read at the position already known from marking archive as read. the option is only available if there is at least one unread chat selected - otherwise, the option is disabled. counterpart of deltachat/deltachat-android#3130
…ing 1 if selections is not started, checking different sets of selections wrt pinning)
r10s
force-pushed
the
r10s/mark-selection-read
branch
from
cc30a1f to
8c82e40
Compare
zeitschlag
approved these changes
Jul 4, 2024
| @@ -691,7 +691,7 @@ class ChatListViewController: UITableViewController { | |||
| return false | |||
| } | |||
| titleView.accessibilityHint = nil | |||
| let cnt = tableView.indexPathsForSelectedRows?.count ?? 1 | |||
| let cnt = tableView.indexPathsForSelectedRows?.count ?? 0 | |||
There was a problem hiding this comment.
It took me a while to understand what cnt stands for
There was a problem hiding this comment.
leaving vocals out to make names shorter is a thing maybe only ppl understand growing up with 8+3 filename and other restrictions, hard to get rid of this habit obviously :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first commit adds an option to mark selected chats as read at the position already known from marking archive as read. the option is only available if there is at least one unread chat selected - otherwise, the option is disabled.
the second commit cleans up a bit, removing a probably unneeded hack, see commit message for details.
counterpart of deltachat/deltachat-android#3130