Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when tapping 'Chats' multiple times, end search #2239

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

r10s
Copy link
Member

@r10s r10s commented Jul 16, 2024

when tapping 'Chats' when chats is already selected, the gist is to bring the view into kind of default - so that you see eg. the messages annonced by a badge counter.

PR #2127 did a scroll-to-top for this purpose,
this PR additionally ends search.

closes #2171

@r10s r10s requested a review from zeitschlag July 16, 2024 12:05
when tapping 'Chats' when chats is already selected,
the gist is to bring the view into kind of default -
so that you see eg. the messages annonced by a badge counter.

PR #2127 did a scroll-to-top for this purpose,
this PR additionally ends search.
@r10s r10s force-pushed the r10s/end-search-on-multiple-chats-taps branch from 98b8739 to e78ce48 Compare July 16, 2024 12:08
Copy link
Collaborator

@zeitschlag zeitschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "quit"-animation feels a bit clunky but it does what it should do: End the search 👍

@r10s r10s merged commit d05bb32 into main Jul 16, 2024
1 check passed
@r10s r10s deleted the r10s/end-search-on-multiple-chats-taps branch July 16, 2024 18:37
@zeitschlag zeitschlag added this to the 1.46.8 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subsequent taps on "Chats" should end search
2 participants