Add heart, thumbs up/down as default-reactions to frequently used rea… #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
great, job! few code, quite some effect. apart from two missing emoji lgtm. - i assume this PR was where https://simgenie.app helped again?
zeitschlag
force-pushed
the
2112-default-emojis
branch
from
8d395b5 to
c3df178
Compare
|
peefect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctions if there are none (#2112)
This is a bit ... hacky as we reverse-engineered (lol, I just looked at the code) and use the way
MCEmojiPickeruses to keep track of those frequently used emojis. I'm fine with this as we forkedMCEmojiPicker.For now,
DefaultReactions(red heart, thumbs up/down, very funny, not so funny) are used to prepopulate the "Frequently used emojis":