Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two chats to placeholder-widget #2465

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Conversation

zeitschlag
Copy link
Collaborator

Adds two round icons to the preview when adding a widget. (Feel free replace the assets, should be pretty straight forward)

Simulator Screenshot - iPhone 16 Pro - 2024-12-26 at 17 08 48

Closes #2462

@zeitschlag zeitschlag requested a review from r10s December 26, 2024 16:09
@zeitschlag zeitschlag self-assigned this Dec 26, 2024
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! one question and one suggestion, but these are no blockers :)

"author" : "xcode",
"version" : 1
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are these changes related? does that already target #2461 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't. It's just to make Xcode not show a warning about a missing accent color.

DcWidget/WidgetProvider.swift Show resolved Hide resolved
@r10s r10s added the widget label Dec 27, 2024
@zeitschlag zeitschlag merged commit 19ae52f into main Dec 28, 2024
1 check passed
@zeitschlag zeitschlag deleted the 2462-chats-in-placeholder branch December 28, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

widget preview should also show "chats" as examples
2 participants