Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickLook swipe down and less message motion when coming back from GiveBackMyFirstResponder #2482

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

QuickLook swipe down and less message motion when coming back from GiveBackMyFirstResponder #2482

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef76b33
QuickLook vc can now be swiped away more consistently
Amzd Jan 5, 2025
575cc15
better animations
Amzd Jan 5, 2025
6a60f2a
fix animation after swiping to different image in quick look
Amzd Jan 5, 2025
68a2c64
fix quick look preview dismiss animation for images not on the screen
Amzd Jan 5, 2025
bee87a1
prevent wrong image in reused cells
Amzd Jan 5, 2025
180bcee
fixed animation for iOS 17 and 18
Amzd Jan 11, 2025
d43cd6f
iOS 18 missing bars workaround
Amzd Jan 11, 2025
83b5e0e
adapt to #2536
Amzd Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
prevent wrong image in reused cells
  • Loading branch information
@Amzd
Amzd committed Jan 29, 2025
commit bee87a1116eec186b5546b431038c93a43c35e48
2 changes: 1 addition & 1 deletion deltachat-ios/Chat/ChatViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2637,7 +2637,7 @@ extension ChatViewController: QLPreviewControllerDelegate {
tableView.scrollToRow(at: indexPath, at: .none, animated: false)
}
if let cell = tableView.cellForRow(at: indexPath) as? BaseMessageCell,
let snapshot = cell.messageBackgroundContainer.snapshotView(afterScreenUpdates: false) {
let snapshot = cell.messageBackgroundContainer.snapshotView(afterScreenUpdates: true) {
if cell is ImageTextCell { // hide cell while transitioning
cell.layer.opacity = 0
}
Expand Down