Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrvUSD mainnet integration + CI fixes #1215

Merged
merged 12 commits into from
Dec 2, 2024
Merged

scrvUSD mainnet integration + CI fixes #1215

merged 12 commits into from
Dec 2, 2024

Conversation

MazyGio
Copy link
Contributor

@MazyGio MazyGio commented Nov 15, 2024 •
edited
Loading

This PR adds an integration for the scrvUSD yield source (ERC4626). It also includes fixes to CI scripts that were hanging.

@coveralls
Copy link
Collaborator

coveralls commented Nov 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12121797961

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.263%
Totals Coverage Status
Change from base Build 12028942371: 0.0%
Covered Lines: 2860
Relevant Lines: 3204
💛 - Coveralls

@MazyGio MazyGio force-pushed the mazygio/integration/scrvusd branch from 55664d8 to 0ef32bc Compare November 15, 2024 17:09
@MazyGio MazyGio changed the title scrvUSD mainnet integration - test scrvUSD mainnet integration Nov 15, 2024
@MazyGio MazyGio marked this pull request as ready for review November 18, 2024 05:54
@sentilesdal sentilesdal force-pushed the mazygio/integration/scrvusd branch 4 times, most recently from 9df6e64 to e07a1e7 Compare November 21, 2024 19:07
@MazyGio MazyGio enabled auto-merge November 25, 2024 15:11
@MazyGio MazyGio changed the title scrvUSD mainnet integration scrvUSD mainnet integration + CI fixes Nov 26, 2024
mcclurejt
mcclurejt approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MazyGio MazyGio added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
jalextowle
jalextowle approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description. Otherwise LGTM

@MazyGio MazyGio added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@MazyGio MazyGio added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@MazyGio MazyGio added this pull request to the merge queue Dec 2, 2024
@MazyGio MazyGio removed this pull request from the merge queue due to a manual request Dec 2, 2024
@MazyGio MazyGio force-pushed the mazygio/integration/scrvusd branch from 7c0335e to 1866289 Compare December 2, 2024 14:47
@MazyGio MazyGio added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 77a52c9 Dec 2, 2024
35 checks passed
@MazyGio MazyGio deleted the mazygio/integration/scrvusd branch December 2, 2024 15:53
@MazyGio MazyGio mentioned this pull request Jan 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcclurejt mcclurejt mcclurejt approved these changes

@jalextowle jalextowle jalextowle approved these changes

@jrhea jrhea Awaiting requested review from jrhea jrhea is a code owner

@cashd cashd Awaiting requested review from cashd

@sentilesdal sentilesdal Awaiting requested review from sentilesdal sentilesdal is a code owner

@dpaiton dpaiton Awaiting requested review from dpaiton

@slundqui slundqui Awaiting requested review from slundqui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MazyGio @coveralls @mcclurejt @jalextowle @sentilesdal