Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade firebase CLI version to 12.7.0 #1434

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

MosheEichler
Copy link
Contributor

Status

Ready/In Progress/In Hold (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

@MosheEichler MosheEichler self-assigned this Dec 7, 2023
@MosheEichler MosheEichler enabled auto-merge (squash) December 7, 2023 16:23
@MosheEichler MosheEichler requested review from MichaelYochpaz and removed request for kobymeir December 7, 2023 17:00
@MichaelYochpaz
Copy link
Contributor

MichaelYochpaz commented Dec 7, 2023

In a future PR, let's update the script to:

FIREBASE_VERSION=12.7.0
curl -sL firebase.tools | sed "s/DOWNLOAD_URL=.*/DOWNLOAD_URL=https:\/\/firebase.tools\/bin\/\$MACHINE\/v$FIREBASE_VERSION/" | bash

So that it'll be more specific (replace the DOWNLOAD_URL variable assignment value instead of every occasion of the word latest), and allow us to configure the version from a simple variable.

@MosheEichler MosheEichler merged commit 6e1f746 into master Dec 7, 2023
7 of 8 checks passed
@MosheEichler MosheEichler deleted the downgrade-firbase-CLI-version branch December 7, 2023 17:32
@xsoar-bot
Copy link

Production Site Updated

Congratulations! The automatic build has completed successfully.
The production site of our docs has been updated. You can view it at: https://xsoar.pan.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants