Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Splunk Add-on Article #1470

Merged
merged 9 commits into from
Feb 6, 2024
Merged

Update Splunk Add-on Article #1470

merged 9 commits into from
Feb 6, 2024

Conversation

MichaelYochpaz
Copy link
Contributor

Status

In Progress

Related Issues

fixes: link to the issue

Description

Update the Splunk Add-on article

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1470-gks9z67y.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@MichaelYochpaz MichaelYochpaz force-pushed the update-splunk-add-on-article branch 2 times, most recently from 3711349 to 778113b Compare January 24, 2024 16:24
@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1470-gks9z67y.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@MichaelYochpaz MichaelYochpaz force-pushed the update-splunk-add-on-article branch from 778113b to e06def7 Compare January 25, 2024 12:15
@MichaelYochpaz MichaelYochpaz marked this pull request as ready for review January 25, 2024 12:15
@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1470-gks9z67y.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1470-gks9z67y.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

eyalpalo
eyalpalo reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@eyalpalo eyalpalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! see my comments, and lets move it to doc review.

content-repo/extra-docs/articles/splunk-add-on.md Outdated
```

### Logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move it up before the troubleshooting, it is important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You meant to the top of the "Troubleshooting" section like I did here, or as a separate top-level header (## Logs) above "Troubleshooting"?

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1470-gks9z67y.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1470-gks9z67y.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

ShirleyDenkberg
ShirleyDenkberg reviewed Feb 1, 2024
View reviewed changes
@ShirleyDenkberg
Copy link
Contributor

@eyalpalo @MosheEichler Doc review completed.

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1470-gks9z67y.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@MichaelYochpaz MichaelYochpaz force-pushed the update-splunk-add-on-article branch from 8bf0301 to 10cda2e Compare February 4, 2024 11:54
@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1470-gks9z67y.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@MichaelYochpaz MichaelYochpaz requested a review from bziser February 4, 2024 14:05
@MichaelYochpaz MichaelYochpaz merged commit bdb3d5d into master Feb 6, 2024
8 checks passed
@MichaelYochpaz MichaelYochpaz deleted the update-splunk-add-on-article branch February 6, 2024 13:21
@xsoar-bot
Copy link

Production Site Updated

Congratulations! The automatic build has completed successfully.
The production site of our docs has been updated. You can view it at: https://xsoar.pan.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@MosheEichler MosheEichler MosheEichler approved these changes

@bziser bziser bziser approved these changes

@eyalpalo eyalpalo eyalpalo approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MichaelYochpaz @xsoar-bot @ShirleyDenkberg @MosheEichler @bziser @eyalpalo