Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[required(<count>)] #976

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Conversation

littledivy
Copy link
Member

Equivalent to Deno's webidl.requiredArguments internal.

#[fast]
#[required(2)]
fn set_item(
  &self,
  state: &mut OpState,
  #[string] key: &str,
  #[string] value: &str,
) {
 // ...
}

@littledivy littledivy changed the title Add #[required(<count>) Add #[required(<count>)] Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 89.87342% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (0c7f83e) to head (d2c5af7).
Report is 179 commits behind head on main.

Files with missing lines Patch % Lines
ops/op2/dispatch_slow.rs 84.61% 6 Missing ⚠️
ops/op2/signature.rs 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
+ Coverage   81.43%   81.78%   +0.34%     
==========================================
  Files          97       98       +1     
  Lines       23877    25740    +1863     
==========================================
+ Hits        19445    21052    +1607     
- Misses       4432     4688     +256     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

ops/op2/dispatch_slow.rs Outdated Show resolved Hide resolved
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 14c6c2e into denoland:main Nov 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants