Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding the main navigation to the mobile nav sidebar, #1259

Merged
merged 7 commits into from
Dec 13, 2024
Merged

adding the main navigation to the mobile nav sidebar, #1259

merged 7 commits into from
Dec 13, 2024

Conversation

thisisjofrank
Copy link
Collaborator

adding a totop button to the API ref docs, adding the mobile nav to the API docs

@thisisjofrank
adding the main navigation to the mobile nav sidebar, adding a totop …
cfe2941 
…button to the API ref docs, adding the mobile nav to the API docs
philhawksworth
philhawksworth approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@philhawksworth philhawksworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I see one slight issue with the sidebar scrolling away in the APIs sections. But I think we'd be better shipping this and addressing that as a fast follow than not having the ability to navigate around on mobile.

@thisisjofrank thisisjofrank merged commit 4f7a265 into main Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philhawksworth philhawksworth philhawksworth approved these changes

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisjofrank @philhawksworth