Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add more explicit types #4018

Merged
merged 3 commits into from
Dec 22, 2023
Merged

chore: add more explicit types #4018

merged 3 commits into from
Dec 22, 2023

Conversation

dsherret
Copy link
Member

This will further help with deno doc output.

dsherret
dsherret commented Dec 21, 2023
View reviewed changes
log/mod.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua suggested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit types for arguments with default values don't appear to be needed.

bytes/last_index_of_needle.ts Show resolved Hide resolved
io/slice_long_to_bytes.ts Show resolved Hide resolved
@dsherret dsherret mentioned this pull request Dec 22, 2023
Open
@dsherret dsherret marked this pull request as ready for review December 22, 2023 00:20
dsherret
dsherret commented Dec 22, 2023
View reviewed changes
log/mod.ts Outdated Show resolved Hide resolved
@iuioiua
Copy link
Contributor

iuioiua commented Dec 22, 2023

Towards #3764 and #3878.

iuioiua
iuioiua approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua iuioiua merged commit ceb107f into denoland:main Dec 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
bytes http io log path streams yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @iuioiua