chore: add more coverage tasks to deno.json
#6395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6395 +/- ##
==========================================
- Coverage 96.11% 96.08% -0.04%
==========================================
Files 557 558 +1
Lines 42156 42190 +34
Branches 6373 6375 +2
==========================================
+ Hits 40520 40537 +17
- Misses 1597 1614 +17
Partials 39 39 ☔ View full report in Codecov by Sentry. |
kt3k
reviewed
Feb 12, 2025
deno.json
Outdated
| @@ -24,10 +24,13 @@ | |||
| "typos": "typos -c ./.github/workflows/typos.toml", | |||
| "build:crypto": "deno task --cwd crypto/_wasm wasmbuild", | |||
| "wasmbuild": "deno run -A jsr:@deno/[email protected] --js-ext mjs --sync", | |||
| "cov": "deno coverage --ignore=\"**/*.generated.mjs,**/_test_utils.ts,.github\"", | |||
| "cov": "deno task test --coverage --clean --reporter=dot && deno coverage --ignore=\"**/*.generated.mjs,**/_test_utils.ts,.github\"", | |||
There was a problem hiding this comment.
This seems causing the entire test cases run multiple times in CI. Can you also modify ci.yml to fix that?
kt3k
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody really asked for this type of change, but I have found it quite useful so hope it gets merged.
Essentially this change adds three new tasks to
deno.json.deno task cov:macdeno task cov:lindeno task cov:winCalling the one for your respective system will go through the process of generating the coverage reports and then open it with whatever your default application is for html files. Most likely your browser.
This pull request also makes the change of removing doc examples from being included in the coverage seen as, from my point of view, the doc examples aren't meant to be proving the validity of the code.