Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli/unstable): Declare ProgressBar options as separate properties #6433

Conversation

timreichen
Copy link
Contributor

Ref: #6408 (comment)

This PR removes ProgressBar #options property in favour of separate private properties.

@timreichen timreichen requested a review from kt3k as a code owner February 20, 2025 08:44
@github-actions github-actions bot added the cli label Feb 20, 2025
@timreichen timreichen changed the title refactor(cli/unstable): Declare options as separate properties refactor(cli/unstable): Declare ProgressBar options as separate properties Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (360851f) to head (81e6935).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6433   +/-   ##
=======================================
  Coverage   96.03%   96.04%           
=======================================
  Files         562      562           
  Lines       42418    42431   +13     
  Branches     6387     6385    -2     
=======================================
+ Hits        40738    40754   +16     
+ Misses       1641     1638    -3     
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Feb 21, 2025

What is resolved by this change? I can't correlate this change with the linked comment

@timreichen
Copy link
Contributor Author

What is resolved by this change? I can't correlate this change with the linked comment

This paves the way for PRs that make some props like max public.
Also, wrapping these props in an object is not necessary in general because the object is not used or passed anywhere.

@BlackAsLight
Copy link
Contributor

I think it would make more sense for the pull request to actually be apart of the other one where value is exposed?

@timreichen
Copy link
Contributor Author

Closing in favour of #6430

@timreichen timreichen closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants