[poed]Merging new poed init flow and error handling rules #19

leonchiang · 2021-12-29T11:06:26Z

Merging new poed init flow and error handling rules
For poecli add config related commands
Fix some I2C communication issues.
Fix exclusive lock flow

…vironment 1. Change service file permission (-x) 2. Add PYTHONUNBUFFERED=1 environment, for quicker dump stdout output. Signed-off-by: leon.chiang <[email protected]>

1. Modify exclusive lock with 5 times retry(delay 0.1s), set lock flag if lock successful, then check lock flag to execute wrapped function. 2. Move some const define in poed to poe_common.py. Signed-off-by: leon.chiang <[email protected]>

1. Add new sub command "poecli cfg" for manipulate config files. 2. Add busy flag between poed and poecli to prevent incorrect setting when the poed still initialization. 3. Change poecli command: 3.1. save->savechip 3.2. restore->restore_poe_system 4. Fix reconstruct flow if presistant config file loss. 5. Stop auto save presistent 30s loop. Signed-off-by: leon.chiang <[email protected]>

1. Remove Enable All ports in init function, 2. Remove save_system_settings in platform init function. Signed-off-by: leon.chiang <[email protected]>

1. Add I2C bus clear delay in TX/RX retry loop. 2. Add reset chip delay 300ms defines. 3. Print retry package content for debug. 4. Remove some space in lines (Refine code). 5. Add delay 30ms between command reports and next command(Key=0x00). Signed-off-by: leon.chiang <[email protected]>

…o stderr 1.Fix poecli exit code passing issue. Ex: root@localhost:~# poecli set -p 0 -e 1 > /dev/null usage: poecli.py set [-h] -p <val> [-e <val>] [-l <val>] [-o <val>] poecli.py set: error: argument -p/--ports: Invalid port inputs: '0'. root@localhost:~# echo $? 2 root@localhost:~# poecli set -p 1 -e 1 > /dev/null root@localhost:~# echo $? 0 2. Redirect all Exception print to stderr. Signed-off-by: leon.chiang <[email protected]>

1. Change platform init flow in poe agent and all supported platform. 2. On startup, clear read buffer for resolve protocol KEY mismatch during initialization platform. 3. Fast compare current active matrix with platform default matrix, skip set/program active matrix if matched. 4. Add driver support read active matrix function(Parser/Return value). Signed-off-by: leon.chiang <[email protected]>

Add failsafe mode when load/apply cfg setting fail, will disable all ports. Signed-off-by: leon.chiang <[email protected]>

1. Add return code if set commands. 2. Add return code structure parsing in init_poe flow (all platform will return the detail results). 3. Modify ports setting checking rules (set_all_params). 4. Add traceback function to identify detail exceptions. Signed-off-by: leon.chiang <[email protected]>

1. Fix communication retry echo byte regenerate. 2. Read 15 bytes when I2C bus initialized in all platform, avoid read mismatch package. 3. Suppress log message when exclusive lock success. 4. Skip powerlimit result checking in 802.3BT mode. Signed-off-by: leon.chiang <[email protected]>

1. Skip read all port enDis state for BT type Chip (not support). 2. Print recv buffer when retry _communication. Signed-off-by: leon.chiang <[email protected]>

rothcar

I've tested this locally on an Accton BT-capable system and the results look good. We do need additional reviewers, though, specifically from Accton.

akenliu · 2022-01-03T01:33:44Z

There are many commits. Does it mean these commits can fix the issues#9~#18?

leonchiang · 2022-01-03T02:02:55Z

There are many commits. Does it mean these commits can fix the issues#9~#18?

Yes, these commits include hotfixs of issues #9~#18 .

WillyLiu-EC · 2022-01-05T06:48:50Z

Hi @leonchiang,

Some questions:
Q1. There a failed message as below after power on.
[ OK ] Started Update UTMP about System Runlevel Changes.