Update testbed configs #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed all testbeds friendlyName to be consistent with sit testbed. Grouped testbeds with serial console and pdu devices Signed-off-by: hubogee <[email protected]> Signed-off-by: hubogee <[email protected]>
hubogee
force-pushed
the
pr_update_testbed_configs2
branch
from
a242055
to
dd56e16
Compare
mgheorghe
requested changes
Aug 29, 2023
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "devices": [ | |||
| { | |||
| "friendlyName":"DENT aggregation 1", | |||
| "friendlyName":"Dent agg1", | |||
There was a problem hiding this comment.
why change? that is just a human readable name
There was a problem hiding this comment.
Because the sit testbed.json and individual testbed testbed.json files should be consistent with the property values. Since test could use either one of the testbed.json files, the dent test framework I am developing uses the friendlyName for some logics. So it's best that all property values are the same.
| "login": "dent", | ||
| "password": "dent123!", | ||
| "number": 5 | ||
| }, | ||
| "serialDev":"/dev/ttyUSB0", |
| "login": "dent", | ||
| "password": "dent123!", | ||
| "number": 5 | ||
| }, | ||
| "serialDev":"/dev/ttyUSB0", |
mgheorghe
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed all testbeds friendlyName to be consistent with sit testbed. Grouped testbeds with serial console and pdu devices