Workflow Event Editor #13
Conversation
22MGreen
requested review from
mgaoVA,
Pelentan,
aerinkayne,
pete-nerantzinis,
shaneodd,
jampaul3,
nk2136 and
KCN8
as code owners
|
This test is not working, tried on a couple different machines and get the same error. This was tested with the master branch. |
|
|
||
| //Create a New Event | ||
| test ('CreateEvent', async ({ page, workflowData}, testinfo) => { | ||
| await page.goto('https://host.docker.internal/Test_Request_Portal/admin/?a=workflow'); |
There was a problem hiding this comment.
This line, and similar lines in other tests are redundant.
There was a problem hiding this comment.
remove the first line from all test
| await page.getByLabel('Close Modal').click(); | ||
|
|
||
| const screenshot = await page.screenshot() | ||
| await testinfo.attach('screenshot', { body: screenshot, contentType: 'image/png' }); |
There was a problem hiding this comment.
The screenshot should be taken prior to closing the modal in order to show the new events.
There was a problem hiding this comment.
added more screenshots
| await page.getByRole('button', { name: 'Close' }).click(); | ||
|
|
||
|
|
||
| const screenshot = await page.screenshot(); |
There was a problem hiding this comment.
Same as above. Screenshots are not useful if they don't show the expected change.
| await page.getByRole('button', { name: 'Save' }).click(); | ||
|
|
||
| await page.getByLabel('List of Events').click(); | ||
| //Verify new event is added |
| //End of 1st Test (Create New Event) | ||
|
|
||
| // Select Newly Created Event from dropdown | ||
| test('Add Event from ddown', async ({ page, workflowData }, testInfo) => { |
There was a problem hiding this comment.
Going through these tests, I have this same issue. Ran on 2 different machines, rebuilt from scratch on the secondary machine.
There was a problem hiding this comment.
This specific test is still giving me issues as well.
Ensure your local database is synced with the Standard Test DB by running the API tester. This should be done if you've made any changes outside of these test. |
|
|
||
| } | ||
|
|
||
| export const test = baseTest.extend<WorkflowFixture>({ |
There was a problem hiding this comment.
A fixture is probably unnecessary for this purpose. See example.
|
Made updates to this PR to include:
|
…icates, edit a event then remove an event
|
|
There was a problem hiding this comment.
-
Please ensure this is up-to-date with the main branch, as it's difficult to determine if there are conflicts with existing tests.
-
Filenames should be aligned to their functional location. By prefixing the file with its functional location: "adminPanelWorkflowEditor", it will be easier to keep files organized over time. Consider renaming it to
adminPanelWorkflowEditor-events.spec.ts, or similar. -
Test names must be aligned to the test plan
Workflow test