Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated unauthenticated prefill alert, uneditable card components & usage example under Prefill pattern #1462

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bellepx0
Copy link
Contributor

@bellepx0 bellepx0 commented Jan 24, 2025

Chromatic

https://update-prefill-pattern-unauth-alert--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

Closes ticket #288 and ticket #291

  • Updated Unauthenticated prefill alert component in Pattern/Prefill section to match Figma design.
  • Updated Card - Uneditable in Pattern/Prefill section to remove gender
  • Updated Usage Examples/Prefilled info with uneditable card to remove gender and fix language and phone links in the note.

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Screenshot 2025-01-24 at 10 54 18 AM

Screenshot 2025-02-03 at 2 06 22 PM

Screenshot 2025-02-03 at 2 06 36 PM

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@bellepx0 bellepx0 marked this pull request as ready for review January 24, 2025 18:56
@bellepx0 bellepx0 requested a review from a team as a code owner January 24, 2025 18:56
@bellepx0 bellepx0 added the ignore-for-release Used if you want to ignore the PR in the generated release notes label Jan 24, 2025
@bellepx0 bellepx0 marked this pull request as draft January 28, 2025 18:52
@bellepx0 bellepx0 marked this pull request as ready for review February 3, 2025 22:10
@bellepx0 bellepx0 changed the title Updated unauthenticated prefill alert component under Prefill pattern Updated unauthenticated prefill alert, uneditable card components & usage example under Prefill pattern Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Used if you want to ignore the PR in the generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Unauthenticated intro prefill alert in VADS Storybook
1 participant