Dm 4260 fix paginated practice card images (#724)

* move `#replaceImagePlaceholders` methods to `_practice_card_utilities`

refactors to be more readable, removes argument as it will always be the same for practice cards

* add include tags for `practice_card_utilities` and `signed_resource`

* add invocation of `replaceImagePlaceholders` where practice cards have been loaded

* edit `practice_card.html.erb` to always render placeholder

* edit invocation of `#replaceImagePlaceholders` to no longer use argument

* edit `#buildPracticeCard` function to include `data-practice-name` in `practice-card-img-placeholder` div

remove `#replaceImagePlaceholders`, `#replacePlaceholderWithImage`, and `#loadImage` functions

update invocation of `#replaceImagePlaceholders` to no longer use argument

edit invocation of `#replaceImagePlaceholders` to no longer use argument

* refactor `#replacePlaceholderWithImage` function as per CodeQl warning: "DOM text reinterpreted as HTML"

* add explicit export of function as per CodeQl warning: "Unused function"

* remove `export` from `replaceImagePlaceholders` function

* add invocation of `replaceImagePlaceholders`

* edit `replacePlaceholderWithImage` function to replace `.practice-card-img-placeholder` div class with `.practice-card-img` class

app/assets/javascripts/_practice_card_utilities.es6

@@ -39,7 +39,7 @@ function toggleFocusStylingForPracticeTitle() {
     });
 }
 
-export function replaceImagePlaceholders() {
+function replaceImagePlaceholders() {
     $('.dm-practice-card').each(function() {
         const placeholder = $(this).find('.practice-card-img-placeholder');
 
@@ -67,7 +67,11 @@ function replacePlaceholderWithImage(imageUrl, practiceId, practiceName) {
             .addClass('dm-practice-card-img-container')
             .append(imgElement);
 
-        $('.practice-card-img-placeholder[data-practice-id="' + practiceId + '"]').empty().append(containerDiv);
+        const placeholder = $('.practice-card-img-placeholder[data-practice-id="' + practiceId + '"]');
+        placeholder.empty()
+                   .append(containerDiv)
+                   .removeClass('practice-card-img-placeholder')
+                   .addClass('practice-card-img');
     });
 }
 

app/views/page/show.js.erb

@@ -46,6 +46,8 @@ function paginatedPageComponent() {
     // If there isn't another set, remove the current 'Load more' link and add proper margin to the container
     $(currentPageClass).remove();
   <% end %>
+
+  replaceImagePlaceholders();
 }
 
 $(paginatedPageComponent)