dm-4881 dom text reinterpret / xss codeql warning 3 #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipDeFraties
changed the title
camillevilla
requested changes
Nov 28, 2024
camillevilla
force-pushed
the
dm-4881-fix-dom-text-reinterpret-codeql-warning-3
branch
from
ae9a3b6 to
0c923d2
Compare
…scape potentially harmful chars to prevent xss vulnerability
camillevilla
force-pushed
the
dm-4881-fix-dom-text-reinterpret-codeql-warning-3
branch
from
0c923d2 to
10bbac5
Compare
camillevilla
approved these changes
Dec 6, 2024
camillevilla
deleted the
dm-4881-fix-dom-text-reinterpret-codeql-warning-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue link
https://agile6.atlassian.net/browse/DM-4881
Description - what does this code do?
updates innovation show page js function setMoreLessHTML to properly escape potentially harmful chars to prevent xss vulnerability
Testing done - how did you test it/steps on how can another person can test it
On an innovation show page leave a long comment, verify that once persisted the comment text properly paginates with the "See more" / "See less" buttons.
Screenshots, Gifs, Videos from application (if applicable)
Link to mock-ups/mock ups (image file if you have it) (if applicable)
Acceptance criteria
Definition of done