Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-5278 metrics page refactor #1136

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Nov 29, 2024

JIRA issue link

https://agile6.atlassian.net/browse/DM-5278

Description - what does this code do?

Refactors /innovations/{innovation slug name}/edit/metrics endpoint to unblock the "all time" page from timing out on deployed apps.

Simplifies and reduces queries, moves some logic to models as scopes

Testing done - how did you test it/steps on how can another person can test it

  1. Locally, before checking out to this branch, go to the metrics page for a few innovations, take screenshots of the data for both "the last 30 days" and "all time" for each section.
  2. Check out to this branch, be sure to reset local server, repeat step 1 and verify the data shown is the same for each innovation.

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Temporary task needed to gather data about a practice in order to closely replicate data to be used to analyze queries run for the metrics endpoint
@PhilipDeFraties PhilipDeFraties changed the title DM-5278 add practice task namespace with task for pulling metrics DM-5278 metrics page refactor Nov 29, 2024
@PhilipDeFraties PhilipDeFraties force-pushed the dm-5278-metrics-page-refactor branch 6 times, most recently from eb8b04c to 3cf90ce Compare December 2, 2024 23:04
@PhilipDeFraties PhilipDeFraties marked this pull request as ready for review December 3, 2024 20:42
…to add joins to include records in the return that belong to ClinicalResourceHubs
…fusion_histories that belong to facilities and not crh's
@PhilipDeFraties PhilipDeFraties merged commit 6c4859c into master Dec 3, 2024
3 of 4 checks passed
@PhilipDeFraties PhilipDeFraties deleted the dm-5278-metrics-page-refactor branch December 3, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant