-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm-4256 refactor practice card img placeholders for pagebuilder show and facility show #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactors to be more readable, removes argument as it will always be the same for practice cards
… `practice-card-img-placeholder` div remove `#replaceImagePlaceholders`, `#replacePlaceholderWithImage`, and `#loadImage` functions update invocation of `#replaceImagePlaceholders` to no longer use argument edit invocation of `#replaceImagePlaceholders` to no longer use argument
PhilipDeFraties
changed the title
Dm 4256 fix practice card images
dm-4256 fix practice card images
Oct 18, 2023
PhilipDeFraties
changed the title
dm-4256 fix practice card images
dm-4256 refactor practice card img placeholders for innovation and facility show
Oct 18, 2023
…g: "DOM text reinterpreted as HTML"
camillevilla
changed the title
dm-4256 refactor practice card img placeholders for innovation and facility show
dm-4256 refactor practice card img placeholders for pagebuilder show and facility show
Oct 19, 2023
camillevilla
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 good job extracting these functions! It's great that we can reuse our placeholder functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue link
https://agile6.atlassian.net/browse/DM-4256
Description - what does this code do?
The main point of these changes is to make sure that practice card images always start as a background placeholder that is subsequently replaced with the practice card image. This had already been implemented everywhere but for facility and page-builder* show pages, this update adds it for said pages and refactors the involved methods a bit.
Testing done - how did you test it/steps on how can another person can test it
As logged-in admin:
Screenshots, Gifs, Videos from application (if applicable)
Link to mock-ups/mock ups (image file if you have it) (if applicable)
Acceptance criteria
Definition of done