Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-4258: Improve fallback behavior for innovation show page images #725

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

camillevilla
Copy link
Contributor

@camillevilla camillevilla commented Oct 19, 2023

JIRA issue link

DM-4258

Description - what does this code do?

  • This PR improves the fallback behavior for innovation show pages where image requests fail. Previously, captions would be set to 50px wide columns when S3 image requests failed. This PR adds a conditional so that broken image captions appear at full column width instead.

Testing done - how did you test it/steps on how can another person can test it

As an innovation editor:

  1. upload an image that is 50px wide. Give it a caption that is about 190 characters long.
  2. upload an image that is 500px wide. Give it a caption that is about 190 characters long.
  3. Save changes
  4. Go to the innovation page
  5. Confirm that the 500px wide image caption is as wide as the image
  6. Confirm that the narrow image's caption is 450px wide.

Screenshots, Gifs, Videos from application (if applicable)

Before

image003

After

Screenshot 2023-10-19 at 4 48 59 PM

Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@PhilipDeFraties PhilipDeFraties merged commit 989a8c4 into master Oct 19, 2023
@PhilipDeFraties PhilipDeFraties deleted the DM-2458-innovation-page-photo-widths branch October 19, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants