Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dm 4269 fix user page practice images #727

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Oct 26, 2023

JIRA issue link

https://agile6.atlassian.net/browse/DM-4269

Description - what does this code do?

Adds script tags to run practice card image replacement functions for user profile page

Testing done - how did you test it/steps on how can another person can test it

  1. Locally as logged in user, go to a page on which practices can be favorited, such as a facility show page that has created or adopted practices and bookmark a few
  2. Go to your user profile page and verify that the practice card images load and replace the black placeholder background

Screenshots, Gifs, Videos from application (if applicable)

Screenshot 2023-10-26 at 11 24 58 AM

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@PhilipDeFraties PhilipDeFraties marked this pull request as ready for review October 26, 2023 17:29
@PhilipDeFraties PhilipDeFraties self-assigned this Oct 26, 2023
@bradjohnson92008 bradjohnson92008 self-requested a review October 26, 2023 18:43
Copy link
Contributor

@bradjohnson92008 bradjohnson92008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected - Great Job Phil!

@PhilipDeFraties PhilipDeFraties merged commit 68d00a0 into master Oct 26, 2023
3 of 4 checks passed
@PhilipDeFraties PhilipDeFraties deleted the dm-4269-fix-user-page-practice-images branch October 26, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants