Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit practice card util js tag #736

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Edit practice card util js tag #736

merged 2 commits into from
Nov 17, 2023

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Nov 16, 2023 •
edited
Loading

JIRA issue link

Description - what does this code do?

edits javascript_include_tag in search.html.erb, removes deferment and sets 'data-turbolinks-track': 'false'

Testing done - how did you test it/steps on how can another person can test it

nav from home page to search page via the "Browse all innovations" link and verify the practice card images load

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@PhilipDeFraties PhilipDeFraties marked this pull request as ready for review November 17, 2023 00:03
@PhilipDeFraties PhilipDeFraties self-assigned this Nov 17, 2023
camillevilla
camillevilla approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@camillevilla camillevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for verifying in DEV.

@PhilipDeFraties PhilipDeFraties merged commit 16ff7b8 into master Nov 17, 2023
3 of 4 checks passed
@PhilipDeFraties PhilipDeFraties deleted the edit-practice-card-util-js-tag branch November 17, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camillevilla camillevilla camillevilla approved these changes

Assignees

@PhilipDeFraties PhilipDeFraties

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilipDeFraties @camillevilla