Skip to content

Commit

Permalink
#1398 - Remove Twistlock GHA workflow and docs (#2288)
Browse files Browse the repository at this point in the history
  • Loading branch information
coreycarvalho authored Feb 5, 2025
1 parent 3a58a6e commit 1ac76a6
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 73 deletions.
7 changes: 0 additions & 7 deletions .github/actions/build-push-artifacts/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,3 @@ runs:
context: .
push: true
tags: ${{ steps.login-ecr-vaec.outputs.registry }}/notification_api:${{ inputs.ref }}

# - name: Dispatch Twistlock Workflow
# shell: bash
# env:
# GH_TOKEN: ${{ github.token }}
# run: |
# gh workflow run -r main -F image-tag=${{ inputs.ref }} twistlock.yml
50 changes: 0 additions & 50 deletions .github/workflows/twistlock.yml

This file was deleted.

16 changes: 0 additions & 16 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -694,22 +694,6 @@ When adding environment variables to any `<filename>-task-definition.json` file,

---

**Problem**: Github Actions is failing when running the 'Perform twistlock scan' step of the 'build-and-push' job

**Solution**:

1. Navigate to [Twistlock UI](https://twistlock.devops.va.gov/#!/login)
2. Click Monitor -> Vulnerabilities -> Images -> CI
3. You should see your failing scan. Click on it to see what's going on. Usually the issue is due to a vulnerability
that will be fixed soon in the alpine linux version that we're using; Twistlock will tell you the version with the
fix if applicable.
4. If there is a fix, we can just ignore the Twistlock alert for a week because our alpine linux version will probably
update to have the fix soon. Go to Defend -> Vulnerabilities -> CI to pull up the Vulnerability Rules.
5. Click on the existing Rule and scroll down to Exceptions. You can add your exception and set the expiration date to a
week from now.

---

**Problem**: `./Modules/posixmodule.c:10432:5: warning: code will never be executed [-Wunreachable-code]
Py_FatalError("abort() called from Python code didn't abort!");`

Expand Down

0 comments on commit 1ac76a6

Please sign in to comment.