2172 - use apply async instead of delay

department-of-veterans-affairs · Feb 3, 2025 · a89ac4b · a89ac4b
1 parent a126db8
commit a89ac4b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/app/v2/notifications/rest_push.py b/app/v2/notifications/rest_push.py
@@ -48,7 +48,7 @@ def push_notification_helper(schema: dict):
 
     try:
         # Choosing to use the email queue for push to limit the number of empty queues
-        deliver_push.delay(payload)
+        deliver_push.apply_async(payload)
     except (CeleryError, OperationalError):
         current_app.logger.exception('Failed to enqueue deliver_push request')
         response = jsonify(result='error', message='VA Notify service impaired, please try again'), 502

diff --git a/tests/app/integration/test_push_notification.py b/tests/app/integration/test_push_notification.py
@@ -118,7 +118,7 @@ def test_mobile_app_push_notification_celery_exception(
     service = sample_service(service_permissions=[PUSH_TYPE])
     api_key = sample_api_key(service=service)
 
-    mocker.patch('app.v2.notifications.rest_push.deliver_push.delay', side_effect=test_exception)
+    mocker.patch('app.v2.notifications.rest_push.deliver_push.apply_async', side_effect=test_exception)
     push_request_body = {
         'mobile_app': 'VETEXT',
         'template_id': 'some-template-id',

diff --git a/tests/app/v2/notifications/test_push_broadcast_notifications.py b/tests/app/v2/notifications/test_push_broadcast_notifications.py
@@ -106,7 +106,7 @@ def test_does_not_accept_extra_fields(
 class TestPushSending:
     @pytest.fixture()
     def deliver_push_celery(self, mocker):
-        mocker.patch('app.v2.notifications.rest_push.deliver_push.delay')
+        mocker.patch('app.v2.notifications.rest_push.deliver_push.apply_async')
 
     def test_returns_201(self, client, sample_api_key, sample_service, deliver_push_celery):
         service = sample_service(service_permissions=[PUSH_TYPE])
@@ -129,7 +129,7 @@ def test_returns_201_after_read_timeout(
 
     @pytest.mark.parametrize('side_effect', [CeleryError, OperationalError])
     def test_celery_returns_502(self, client, sample_api_key, sample_service, mocker, side_effect):
-        mocker.patch('app.v2.notifications.rest_push.deliver_push.delay', side_effect=side_effect)
+        mocker.patch('app.v2.notifications.rest_push.deliver_push.apply_async', side_effect=side_effect)
         service = sample_service(service_permissions=[PUSH_TYPE])
         response = post_send_push_broadcast_notification(client, sample_api_key(service), PUSH_BROADCAST_REQUEST)
         assert response.status_code == 502
diff --git a/tests/app/v2/notifications/test_push_notifications.py b/tests/app/v2/notifications/test_push_notifications.py
@@ -136,7 +136,7 @@ def test_does_not_accept_extra_fields(
 class TestDeliverPushCelery:
     @pytest.fixture()
     def deliver_push_celery(self, mocker):
-        mocker.patch('app.v2.notifications.rest_push.deliver_push.delay')
+        mocker.patch('app.v2.notifications.rest_push.deliver_push.apply_async')
 
     def test_returns_201(
         self,
@@ -165,7 +165,7 @@ def test_returns_201_after_read_timeout(
 
     @pytest.mark.parametrize('side_effect', [CeleryError, OperationalError])
     def test_celery_returns_502(self, client, sample_api_key, sample_service, mocker, side_effect):
-        mocker.patch('app.v2.notifications.rest_push.deliver_push.delay', side_effect=side_effect)
+        mocker.patch('app.v2.notifications.rest_push.deliver_push.apply_async', side_effect=side_effect)
         service = sample_service(service_permissions=[PUSH_TYPE])
         response = post_send_notification(client, sample_api_key(service), PUSH_TYPE, PUSH_REQUEST)
         assert response.status_code == 502