Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1358 Redact personalization when in final state #2272

Merged
merged 16 commits into from
Jan 29, 2025
Merged

#1358 Redact personalization when in final state #2272

merged 16 commits into from
Jan 29, 2025

Conversation

mchlwellman
Copy link

@mchlwellman mchlwellman commented Jan 27, 2025 •
edited
Loading

Description

This PR redacts personalization in the database when a notification is in a final state.

issue #1358

How Has This Been Tested?

  • Deployed to dev, unit and regression tests pass.
  • Sent an SMS with personalization
Screenshot 2025-01-28 at 8 03 51 AM

Verified:

  • rendered correctly on phone.
  • field is encrypted and redacted in Postgres
Screenshot 2025-01-28 at 8 02 54 AM
  • Sent an email with personalization
Screenshot 2025-01-28 at 8 20 52 AM

Verified:

  • rendered correctly
    Screenshot 2025-01-28 at 8 12 42 AM
  • field is encrypted and redacted in Postgres
Screenshot 2025-01-28 at 8 24 13 AM

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@mchlwellman mchlwellman self-assigned this Jan 27, 2025
@mchlwellman mchlwellman marked this pull request as ready for review January 28, 2025 13:43
@mchlwellman mchlwellman requested a review from a team as a code owner January 28, 2025 13:43
MackHalliday
MackHalliday previously approved these changes Jan 28, 2025
View reviewed changes
app/celery/process_ses_receipts_tasks.py Show resolved Hide resolved
app/dao/notifications_dao.py Show resolved Hide resolved
MackHalliday
MackHalliday reviewed Jan 29, 2025
View reviewed changes
tests/app/celery/test_process_pinpoint_receipt_tasks.py
@@ -375,6 +376,6 @@ def test_process_pinpoint_results_notification_final_status_personalisation(
reference=test_reference, event_type='_SMS.SUCCESS', record_status='DELIVERED'
)
)
notification = notifications_dao.dao_get_notification_by_reference(test_reference)
notify_db_session.session.refresh(notification)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

MackHalliday
MackHalliday approved these changes Jan 29, 2025
View reviewed changes
Copy link

@MackHalliday MackHalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the newest commits since my last approval. I see Dave's suggestions were implemented. Code looks nice and clean 🧹 ✨

@mchlwellman mchlwellman merged commit ec2c84a into main Jan 29, 2025
13 checks passed
@mchlwellman mchlwellman deleted the 1358-redact-personalisation-final branch January 29, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJohnson-CDJ ChrisJohnson-CDJ ChrisJohnson-CDJ left review comments

@MackHalliday MackHalliday MackHalliday approved these changes

@kalbfled kalbfled kalbfled approved these changes

Assignees

@mchlwellman mchlwellman

Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mchlwellman @kalbfled @ChrisJohnson-CDJ @MackHalliday