#2286 missing e-mail subject personalisation errors #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalbfled
force-pushed
the
2286-subject-placeholders
branch
from
6cc0454 to
ad52588
Compare
15 tasks
cris-oddball
reviewed
Feb 6, 2025
| message = 'Missing personalisation: {}'.format(', '.join(template_object.missing_data)) | ||
| def check_placeholders(utils_template_instance): | ||
| if utils_template_instance.missing_data: | ||
| message = 'Missing personalisation: {}'.format(', '.join(utils_template_instance.missing_data)) |
There was a problem hiding this comment.
Nit: since we are here, can we just convert this to f-string format?
Suggested change
| message = 'Missing personalisation: {}'.format(', '.join(utils_template_instance.missing_data)) | |
| message = f"Missing personalisation: {', '.join(utils_template_instance.missing_data)}" |
There was a problem hiding this comment.
In this case, given that the substitution is an expression and not just a variable, I think it's more readable with "format."
k-macmillan
approved these changes
Feb 6, 2025
MackHalliday
approved these changes
Feb 6, 2025
kalbfled
force-pushed
the
2286-subject-placeholders
branch
from
ff9a3d6 to
733f7d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add unit tests and pull in an updated version of Utils. (See the Utils PR.) The goal is that requests to send e-mail using a template with a placeholder in the subject return 400 if the POST data doesn't contain an associated value. The problem was that Utils was only checking for missing values in the content body.
How Has This Been Tested?
I repeated that steps in the ticket to reproduce the problem and observed that it's no longer a problem.
Happy path with template
b2c9ff49-b37b-4352-ab0c-3d3d0710fe4c:Missing subject data:
Missing content data:
Missing subject data with template
64b0953c-b7ea-4b48-b70f-d242ce5b17d2, which only has a placeholder in the subject:Checklist