Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#143 - Upgrade phonenumbers #206

Merged
merged 1 commit into from
Feb 10, 2025
Merged

#143 - Upgrade phonenumbers #206

merged 1 commit into from
Feb 10, 2025

Conversation

kalbfled
Copy link
Member

@kalbfled kalbfled commented Feb 10, 2025 •
edited
Loading

Description

These changes upgrade the Python phonenumbers package to the latest version. The upgrade causes one unit test to fail based on a change in the expected normalized format of an Egyptian phone number. I made the new output the expected output.

How Has This Been Tested?

  • API branch that uses these changes created and deployed; regressions pass

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@kalbfled kalbfled self-assigned this Feb 10, 2025
@kalbfled kalbfled marked this pull request as ready for review February 10, 2025 17:05
@MackHalliday MackHalliday changed the title #143 Upgrade phonenumbers #143 - Upgrade phonenumbers Feb 10, 2025
cris-oddball
cris-oddball approved these changes Feb 10, 2025
View reviewed changes
Copy link

@cris-oddball cris-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but don't we label Utils PRs?

@kalbfled kalbfled added the dependencies Pull requests that update a dependency file label Feb 10, 2025
@kalbfled
Copy link
Member Author

approved, but don't we label Utils PRs?

I added the "dependencies" label.

@kalbfled kalbfled merged commit 08a94e0 into main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanParish EvanParish EvanParish approved these changes

@cris-oddball cris-oddball cris-oddball approved these changes

Assignees

@kalbfled kalbfled

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalbfled @EvanParish @cris-oddball