Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-43491-prevent-wsdl-calls-to-service #20487

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Jan 27, 2025

Summary

  • Makes corrections to prevent WSDL call.

Related issue(s)

Testing done

Postman requests to the following endpoints:

  • EWS submit
  • V2 526 submit
  • V1 526 submit
  • V1 526 upload

Rails c for the following definitions:

@ssl_verify_mode = 
if Settings.bgs.ssl_verify_mode == 'none'
OpenSSL::SSL::VERIFY_NONE
else
OpenSSL::SSL::VERIFY_PEER
end
ClaimsApi::LocalBGS.new(external_uid:'a', external_key:'b').fetch_namespace(Faraday::Connection.new(
    ssl: { verify_mode: @ssl_verify_mode }), 'ClaimantServiceBean/ClaimantWebService')
  • 'ClaimantServiceBean/ClaimantWebService'
  • 'BenefitClaimWebServiceBean/BenefitClaimWebService'
  • 'ClaimManagementService/ClaimManagementService'
  • 'ContentionService/ContentionService'
  • 'CorporateUpdateServiceBean/CorporateUpdateWebService'

What areas of the site does it impact?

modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

Please test and check your local logs for connection_wsdl_get

@stiehlrod stiehlrod self-assigned this Jan 27, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to API-43491-prevent-wsdl-calls-to-service/main/main January 27, 2025 23:55 Inactive
@stiehlrod stiehlrod marked this pull request as ready for review January 28, 2025 18:15
@stiehlrod stiehlrod requested a review from a team as a code owner January 28, 2025 18:15
@stiehlrod stiehlrod merged commit 69f625f into master Jan 29, 2025
22 checks passed
@stiehlrod stiehlrod deleted the API-43491-prevent-wsdl-calls-to-service branch January 29, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants