Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new logic for past and future appointments #20501

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

drewconnelly
Copy link
Contributor

Summary

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Ensure that all appointments returned from the VAOS /appointment and /appointments endpoints contain past, pending, and future boolean values in the base appointment response.

What areas of the site does it impact?

This change impacts the VAOS appointment READ operations.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to 99469-consolidatePastAppointmentLogic/main/main January 28, 2025 20:53 Inactive
Copy link
Contributor

@devin-mccurdy devin-mccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to 99469-consolidatePastAppointmentLogic/main/main January 29, 2025 00:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants