Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[VI-920] updates to MPI add_person_proxy & orchestrated search methods" #20503

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

bosawt
Copy link
Contributor

@bosawt bosawt commented Jan 28, 2025

Reverts #20221

Copy link

1 Warning
⚠️ This PR changes 223 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • app/models/mpi_data.rb (+6/-7)

  • app/policies/mpi_policy.rb (+1/-1)

  • lib/mpi/constants.rb (+1/-0)

  • lib/mpi/messages/find_profile_by_attributes.rb (+5/-1)

  • lib/mpi/service.rb (+21/-0)

  • modules/claims_api/spec/requests/v1/forms/2122_spec.rb (+2/-2)

  • modules/claims_api/spec/requests/v1/forms/526_spec.rb (+17/-9)

  • modules/dhp_connected_devices/spec/requests/dhp_connected_devices/fitbit_spec.rb (+2/-2)

  • modules/dhp_connected_devices/spec/requests/dhp_connected_devices/veteran_device_records_spec.rb (+2/-2)

  • spec/controllers/v1/sessions_controller_spec.rb (+40/-4)

  • spec/factories/users.rb (+0/-1)

  • spec/lib/mpi/messages/find_profile_by_attributes_spec.rb (+24/-0)

  • spec/lib/mpi/service_spec.rb (+30/-0)

  • spec/models/mpi_data_spec.rb (+6/-8)

  • spec/policies/mpi_policy_spec.rb (+4/-10)

  • spec/requests/swagger_spec.rb (+1/-1)

  • spec/requests/v0/mvi_users_spec.rb (+1/-1)

  • spec/requests/v0/user_spec.rb (+7/-2)

  • spec/services/users/services_spec.rb (+1/-1)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast response

@bosawt bosawt enabled auto-merge (squash) January 29, 2025 17:12
@ericboehs ericboehs disabled auto-merge January 29, 2025 17:19
@ericboehs ericboehs merged commit 1f301c4 into master Jan 29, 2025
47 of 48 checks passed
@ericboehs ericboehs deleted the revert-20221-VI-920_mpi_cache_key branch January 29, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants