Implement simple forms notification_email_address

[Thrillberg]

Summary

This is the second part, beginning with this PR of a big refactor of Simple Forms emails. This one implements a method across all our forms, notification_email_address, so we can remove that logic from the NotificationEmail service later on.

[github-actions]

1 Warning

⚠️

This PR changes 244 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/simple_forms_api/app/models/simple_forms_api/base_form.rb (+3/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_20_10206.rb (+3/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_20_10207.rb (+7/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0845.rb (+7/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0966.rb (+7/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0972.rb (+3/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_10210.rb (+9/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_4142.rb (+3/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21p_0847.rb (+3/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_26_4555.rb (+3/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_40_0247.rb (+3/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_40_10007.rb (+3/-0) modules/simple_forms_api/spec/models/base_form_spec.rb (+6/-0) modules/simple_forms_api/spec/models/vba_20_10206_spec.rb (+8/-0) modules/simple_forms_api/spec/models/vba_20_10207_spec.rb (+35/-0) modules/simple_forms_api/spec/models/vba_21_0845_spec.rb (+24/-0) modules/simple_forms_api/spec/models/vba_21_0966_spec.rb (+24/-0) modules/simple_forms_api/spec/models/vba_21_0972_spec.rb (+8/-0) modules/simple_forms_api/spec/models/vba_21_10210_spec.rb (+39/-0) modules/simple_forms_api/spec/models/vba_21_4142_spec.rb (+8/-0) modules/simple_forms_api/spec/models/vba_21p_0847_spec.rb (+8/-0) modules/simple_forms_api/spec/models/vba_26_4555_spec.rb (+8/-0) modules/simple_forms_api/spec/models/vba_40_0247_spec.rb (+8/-0) modules/simple_forms_api/spec/models/vba_40_10007_spec.rb (+14/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger