101426 update AppointmentsController#fetch_drive_times #20510
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/long from user's vet360 data
…y string if user's lat/long are unavailable
randomsync
reviewed
Jan 29, 2025
| @@ -380,6 +380,10 @@ def fetch_provider_slots | |||
| end | |||
|
|
|||
| def fetch_drive_times(provider) | |||
| user_address = current_user.vet360_contact_info&.residential_address | |||
|
|
|||
| return '' unless user_address&.latitude && user_address.longitude | |||
There was a problem hiding this comment.
this looks good. I'm curious how this will get serialized and show up in the response to front-end...should we add a request spec for it, if one doesn't exist already?
There was a problem hiding this comment.
actually, the specs might be a part of department-of-veterans-affairs/va.gov-team#101428 that @devin-mccurdy is working on. if that's the case, this looks good
randomsync
approved these changes
Jan 29, 2025
| @@ -380,6 +380,10 @@ def fetch_provider_slots | |||
| end | |||
|
|
|||
| def fetch_drive_times(provider) | |||
| user_address = current_user.vet360_contact_info&.residential_address | |||
|
|
|||
| return '' unless user_address&.latitude && user_address.longitude | |||
There was a problem hiding this comment.
actually, the specs might be a part of department-of-veterans-affairs/va.gov-team#101428 that @devin-mccurdy is working on. if that's the case, this looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
addressattribute, but that data is obtained from the MPI service and does not include lat/long. Instead we can obtain the lat/long from the user'svet360_contact_infodata if available.Related issue(s)
department-of-veterans-affairs/va.gov-team#101426
Testing done
Acceptance criteria
Requested Feedback
As per John W, return an empty string if the user's lat/long are not available.