Update link/button guidance for downloads #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmithadhoc
temporarily deployed
to
development
GitHub Actions
Inactive
5 tasks
rsmithadhoc
requested review from
babsdenney,
danbrady,
humancompanion-usds and
LWWright7
danbrady
approved these changes
Jan 28, 2025
| @@ -4,3 +4,4 @@ | |||
| - It is important to use Action Links for calls to actions that link to another page rather than buttons, because screen readers always say “link” before links, and “button” before buttons. | |||
| - A good rule is if the action changes the URL, it should not be a button. | |||
| - Button and link confusion can be very frustrating for assistive technology users. A user with a screen reader may pull up a list of links and may not find a specific link because it turns out that it’s been designated as a button in the markup. | |||
| - When a file download is involved, it is best to use a link. This is because links are intended for navigation, and downloading a file is a navigational action to a resource. | |||
There was a problem hiding this comment.
Suggested change
| - When a file download is involved, it is best to use a link. This is because links are intended for navigation, and downloading a file is a navigational action to a resource. | |
| - When a file download is involved, it is best to use the [download link](https://design.va.gov/components/link/#download) component. This is because links are intended for navigation, and downloading a file is a navigational action to a resource. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3579
Updated links vs. button section with a bullet point for download links.