adding sorbet types for elm file parser #11440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robaiken
force-pushed
the
robaiken/adding-sorbet-types-for-elm-file-parser
branch
from
c111a54 to
d55529e
Compare
amazimbe
reviewed
Feb 4, 2025
|
|
||
| sig { override.returns(T::Array[Dependabot::Dependency]) } |
There was a problem hiding this comment.
I don't think you actually need override here
amazimbe
reviewed
Feb 4, 2025
| @@ -149,7 +162,8 @@ def build_elm_json_dependency(name:, group:, requirement:, direct:) | |||
|
|
|||
| sig { returns(String) } | |||
| def repo_type | |||
| parsed_elm_json.fetch("type") | |||
| type = parsed_elm_json.fetch("type") | |||
| T.must(type.is_a?(String) ? type : nil) | |||
There was a problem hiding this comment.
Not sure what this is doing but I think the result is nilable so I don't think the signature should be sig { returns(String) }
amazimbe
reviewed
Feb 4, 2025
| @@ -167,12 +186,17 @@ def version_for(version_requirement) | |||
| req.requirements.first.last | |||
| end | |||
|
|
|||
| sig { returns(T::Hash[String, T.any(String, T::Hash[String, T.any(String, T::Hash[String, String])])]) } | |||
There was a problem hiding this comment.
I would monitor this after deploying. It's too precise and it wouldn't surprise me if it starts erroring.
amazimbe
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Add sorbet types to:
elm/lib/dependabot/elm/file_parser.rbHow will you know you've accomplished your goal?
All tests should continue to pass as before and there shouldn't be any new sorbet runtime errors in Sentry
Checklist