feat(my-recruit): 내 공고 페이지 카드 UI구현 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkrdmstlr3
requested review from
woo-jk,
Collection50 and
eunbeann
as code owners
eunbeann
approved these changes
Aug 12, 2024
| whileTap="touch" | ||
| whileHover="hover" | ||
| className="px-8 py-4 flex items-center gap-[4px] rounded-[4px]"> | ||
| <Icon name={isDateSelected ? 'calendarFill' : 'calendar'} size={20} color="#AEB0B6" /> |
There was a problem hiding this comment.
전에 다른 리뷰에서도 본 것 같긴한데, 이 색만 hex 코드로 쓰신 이유가 따로 있으신거죠..?!!?
Collection50
approved these changes
Aug 13, 2024
src/utils/date.ts
Outdated
Comment on lines
20
to
21
| const dayDifference = differenceInDays(target, today); | ||
| return dayDifference; |
There was a problem hiding this comment.
Suggested change
| const dayDifference = differenceInDays(target, today); | |
| return dayDifference; | |
| return differenceInDays(target, today); |
이렇게는 어떠신가요??
|
리뷰 감사합니닷 이따 저녁에 수정해서 어프룹하겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3. 관련 스크린샷을 첨부해주세요.
2024-08-13.1.11.19.mov
4. 완료 사항
5. 추가 사항 / 코드 리뷰 받고 싶은 부분