chore: refactor away from looking at role attribute #4756
+573
−586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
commented
Apr 22, 2025
| const role = cell.getAttribute('role'); | ||
| if (isValidRole(role)) { | ||
| const role = getExplicitRole(cell); | ||
| if (role) { |
There was a problem hiding this comment.
getExplicitRole already validates the role if it returns, otherwise it returns null for an invalid role. So we don't have to validate it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is in preparation to support fallback roles. Any part of the code that used
.getAttribute('role')or.attr('role')was migrated to usegetEplicitRole()instead. There are a few places that still look at the role attribute directly, but those cases are validating the attributes value for different things so it's a valid use case (e.g. looking for abstract roles, invalid roles, fallback roles, unallowed roles, etc.).Also migrates some of the older test code to use arrow functions and
constrather thanvar(which is a tech debt strategy to slowly update the code as we touch the files).Part of #3768