Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the build system to CMake #520

Closed
wants to merge 5 commits into from
Closed

Changing the build system to CMake #520

wants to merge 5 commits into from

Conversation

1ay1
Copy link

@1ay1 1ay1 commented Jun 7, 2021

Right now the plugin only works on *nix.
On windows the plugin is building but doesn't show up in the Pidgin.

Windows support is underway.

@EionRobb
Copy link
Collaborator

EionRobb commented Jun 7, 2021

That's a shame to lose the commit history of the original plugin. Is it not possible to import all the original commits from the hg repo to keep the history?

@dequis
Copy link
Owner

dequis commented Jun 7, 2021

As I mentioned in #516, the branch called "libpurple-integration" (i didn't pick the name) has that

@1ay1
Copy link
Author

1ay1 commented Jun 7, 2021

It's going to to very complicated to do that, and I don't know hg too well either.
Let's make a new start by paying homage to the original authors everywhere in the code.

"libpurple-integration" could have the commit history because the directory structure is not changed in that branch.
Here I changed the directory structure too and made it a bit simple so that new people can dive into code and help us fix bugs.

"libpurple-integration" branch is solving nothing.

@EionRobb
Copy link
Collaborator

EionRobb commented Jun 7, 2021

I appreciate the work you've done here, but losing the history is a deal-breaker. Keeping the history of changes (to understand the "why") is pretty important for a protocol plugin to understand what makes it tick and what changes can be made without breaking things.

If you want to rebase against the libpurple-integration branch and attach the CMake scripts to that then we can review that PR, but right now this PR is solving nothing

@EionRobb EionRobb closed this Jun 7, 2021
@1ay1
Copy link
Author

1ay1 commented Jun 8, 2021

That's ok, I'm going to continue my work on my fork then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants