[BUGFIX] Fix: setting disableOverrideDemand not working

[SoraNoIseki]

$this->settings['disableOverrideDemand'] ist type string, this method returns always true, while this setting enabled (value '1'), override demand was not disabled.

[derhansen]

Thanks for your PR. However having loose type comperations is not something I want to have in the extension, so the fix must be adapted, so $this->settings['disableOverrideDemand'] is typecasted to int

[derhansen]

Please update your patch to:

return (int)($this->settings['disableOverrideDemand'] ?? 0) !== 1 && $overwriteDemand !== [];

This fixes the problem in a typesafe way. Since the change is some kind of breaking for users (the setting/check is broken since v6 of the extension), I will release it as minor version with a notice of importance.

[derhansen]

Issue #1175

[SoraNoIseki]

Please update your patch to:

return (int)($this->settings['disableOverrideDemand'] ?? 0) !== 1 && $overwriteDemand !== [];

This fixes the problem in a typesafe way. Since the change is some kind of breaking for users (the setting/check is broken since v6 of the extension), I will release it as minor version with a notice of importance.

That's right! I have now updated my patch.