Merge pull request #451 from sandeep-deriv/sandeep/fix-ghworkflow-1

chore: uncommented slack notification for staging
deriv-com · Apr 3, 2024 · d2478d4 · d2478d4
2 parents e2c78f6 + 968f25b
commit d2478d4
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 20 deletions.
diff --git a/.github/actions/send_slack_notifications/action.yml b/.github/actions/send_slack_notifications/action.yml
@@ -14,6 +14,10 @@ inputs:
     description: "Version"
     required: true
     default: "N/A"
+  app_url:
+    description: "App URL"
+    required: true
+    default: "https://bot.deriv.com/"
 runs:
   using: composite
   steps:
@@ -22,11 +26,11 @@ runs:
       uses: 'deriv-com/shared-actions/.github/actions/send_slack_notification@master'
       with:
         SLACK_WEBHOOK_URL: ${{ inputs.SLACK_WEBHOOK_URL }}
-        MESSAGE: ${{ inputs.RELEASE_TYPE }} Release succeeded for binary-bot with version ${{ inputs.VERSION }}
+        MESSAGE: ${{ inputs.RELEASE_TYPE }} Release succeeded for ${{ inputs.APP_URL }} with version ${{ inputs.VERSION }}
 
     - name: Send Slack Notification on Failure
       if: inputs.status == 'failure'
       uses: 'deriv-com/shared-actions/.github/actions/send_slack_notification@master'
       with:
         SLACK_WEBHOOK_URL: ${{ inputs.SLACK_WEBHOOK_URL }}
-        MESSAGE: ${{ inputs.RELEASE_TYPE }} Release failed for binary-bot with version ${{ inputs.VERSION }}
+        MESSAGE: ${{ inputs.RELEASE_TYPE }} Release failed for ${{ inputs.APP_URL }} with version ${{ inputs.VERSION }}
diff --git a/.github/workflows/release_production.yml b/.github/workflows/release_production.yml
@@ -71,4 +71,5 @@ jobs:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
           status: ${{ env.WORKFLOW_CONCLUSION }}
           release_type: Production
-          version: ${{ needs.release_production.outputs.RELEASE_VERSION}}
+          version: ${{ needs.release_production.outputs.RELEASE_VERSION }}
+          app_url: https://bot.deriv.com/
diff --git a/.github/workflows/release_staging.yml b/.github/workflows/release_staging.yml
@@ -46,20 +46,21 @@ jobs:
           SERVICEACCOUNT_TOKEN: ${{ secrets.SERVICEACCOUNT_TOKEN }}
           CA_CRT: ${{ secrets.CA_CRT }}
           APP_VERSION: latest-staging
-  # send_slack_notification:
-  #   if: always()
-  #   needs: [release_staging]
-  #   environment: Staging
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - name: Checkout
-  #       uses: actions/checkout@v4
-  #     - name: Conclusion
-  #       uses: technote-space/workflow-conclusion-action@v3
-  #     - name: Send Slack Notification
-  #       uses: "./.github/actions/send_slack_notifications"
-  #       with:
-  #         SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-  #         status: ${{ env.WORKFLOW_CONCLUSION }}
-  #         release_type: Staging
-  #         version: 'latest-master'
+  send_slack_notification:
+    if: always()
+    needs: [release_staging]
+    environment: Staging
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Conclusion
+        uses: technote-space/workflow-conclusion-action@v3
+      - name: Send Slack Notification
+        uses: "./.github/actions/send_slack_notifications"
+        with:
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+          status: ${{ env.WORKFLOW_CONCLUSION }}
+          release_type: Staging
+          version: latest-master
+          app_url: https://staging-bot.deriv.com/