Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT] chore: remove core ws connection #13

Merged
merged 1 commit into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 97 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
},
"scripts": {
"start": "vite",
"start:dev": "vite-live-preview --reload --port=8443",
"build": "vite build",
"preview": "vite preview",
"test:lint": "prettier --log-level silent --write . && eslint \"./src/**/*.?(js|jsx|ts|tsx)\"",
Expand All @@ -18,7 +19,7 @@
},
"dependencies": {
"@deriv-com/analytics": "^1.5.3",
"@deriv-com/api-hooks": "^0.0.22",
"@deriv-com/api-hooks": "^1.1.1",
"@deriv-com/translations": "^1.2.4",
"@deriv-com/ui": "latest",
"@deriv-com/utils": "latest",
Expand Down Expand Up @@ -111,6 +112,7 @@
"stylelint-selector-bem-pattern": "^4.0.0",
"ts-jest": "^29.1.2",
"typescript": "^5.2.2",
"vite-live-preview": "^0.1.6",
"vite-plugin-svgr": "^4.2.0",
"vite-require": "^0.2.3",
"vite-tsconfig-paths": "^4.3.2",
Expand Down
2 changes: 1 addition & 1 deletion src/app/app-content.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const AppContent = () => {
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

return !is_loading ? (
return is_loading ? (
<Loader />
) : (
<>
Expand Down
2 changes: 1 addition & 1 deletion src/app/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import App from './app';
import App from './App';

export default App;
7 changes: 5 additions & 2 deletions src/external/bot-skeleton/services/api/active-symbols.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { localize } from '@/utils/tmp/dummy';
import { config } from '../../constants/config';
import PendingPromise from '../../utils/pending-promise';

import { api_base } from './api-base';

export default class ActiveSymbols {
constructor(ws, trading_times) {
this.active_symbols = [];
Expand All @@ -25,11 +27,12 @@ export default class ActiveSymbols {
}

this.is_initialised = true;

const { active_symbols } = await this.ws.authorized.activeSymbols();
const active_symbols = api_base?.active_symbols ?? [];

this.active_symbols = active_symbols;
this.processed_symbols = this.processActiveSymbols();

// TODO: fix need to look into it as the method is not present
this.trading_times.onMarketOpenCloseChanged = changes => {
Object.keys(changes).forEach(symbol_name => {
const symbol_obj = this.active_symbols[symbol_name];
Expand Down
7 changes: 7 additions & 0 deletions src/external/bot-skeleton/services/api/api-base.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class APIBase {
time_interval = null;
has_activeSymbols = false;
is_stopping = false;
active_symbols = [];

async init(force_update = false) {
if (getLoginId()) {
Expand All @@ -25,6 +26,11 @@ class APIBase {
if (this.time_interval) clearInterval(this.time_interval);
this.time_interval = null;
this.getTime();
} else {
this.api = generateDerivApiInstance();
if (!this.has_activeSymbols) {
this.getActiveSymbols();
}
}
}

Expand Down Expand Up @@ -103,6 +109,7 @@ class APIBase {
});
this.pip_sizes = pip_sizes;
this.toggleRunButton(false);
this.active_symbols = active_symbols;
});
};

Expand Down
2 changes: 1 addition & 1 deletion src/external/bot-skeleton/services/api/trading-times.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default class TradingTimes {

async updateTradingTimes() {
const last_update_date = this.last_update_moment.format('YYYY-MM-DD');
const response = await this.ws.tradingTimes(last_update_date);
const response = await this.ws?.send({ trading_times: last_update_date });

if (response.error) {
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default Engine =>
observeBalance() {
if (!api_base.api) return;
const subscription = api_base.api.onMessage().subscribe(({ data }) => {
if (data.msg_type === 'balance') {
if (data?.msg_type === 'balance' && data?.balance) {
const {
balance: { balance: b, currency },
} = data;
Expand Down
31 changes: 26 additions & 5 deletions src/hooks/useStore.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import { createContext, useContext, useMemo } from 'react';
import { createContext, useContext, useEffect, useRef, useState } from 'react';

import { Loader } from '@deriv-com/ui';

import { api_base } from '@/external/bot-skeleton';

import Bot from '../external/bot-skeleton/scratch/dbot';
import RootStore from '../stores';
Expand All @@ -10,11 +14,28 @@ type TStoreProvider = {
};

const StoreProvider: React.FC<TStoreProvider> = ({ children }) => {
const memoizedValue = useMemo(() => {
return new RootStore(Bot);
}, []);
const [store, setStore] = useState<RootStore | null>(null);
const initializingStore = useRef(false);

useEffect(() => {
const initializeStore = async () => {
await api_base.init();
const ws = api_base.api;
const rootStore = new RootStore(Bot, ws);
setStore(rootStore);
};

if (!store && !initializingStore.current) {
initializingStore.current = true;
initializeStore();
}
}, [store]);

if (!store) {
return <Loader />;
}

return <StoreContext.Provider value={memoizedValue}>{children}</StoreContext.Provider>;
return <StoreContext.Provider value={store}>{children}</StoreContext.Provider>;
};

const useStore = () => {
Expand Down
7 changes: 0 additions & 7 deletions src/stores/app-store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export default class AppStore {
disposeSwitchAccountListener: unknown;
disposeLandingCompanyChangeReaction: unknown;
disposeResidenceChangeReaction: unknown;
is_dbot_initialized: boolean;

constructor(root_store: RootStore, core: TStores) {
makeObservable(this, {
Expand All @@ -47,7 +46,6 @@ export default class AppStore {
this.dbot_store = null;
this.api_helpers_store = null;
this.timer = null;
this.is_dbot_initialized = false;
}

getErrorForNonEuClients = () => ({
Expand Down Expand Up @@ -148,7 +146,6 @@ export default class AppStore {

blockly_store.setLoading(true);
await DBot.initWorkspace('/', this.dbot_store, this.api_helpers_store, ui.is_mobile, false);
this.is_dbot_initialized = true;

blockly_store.setContainerSize();
blockly_store.setLoading(false);
Expand Down Expand Up @@ -335,10 +332,6 @@ export default class AppStore {
server_time: this.core.common.server_time,
ws: this.root_store.ws,
};

if (!this.is_dbot_initialized) {
this.onMount();
}
};

onClickOutsideBlockly = (event: Event) => {
Expand Down
Loading
Loading