Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

henry/grwt-3242/chore: quill-icons package update #17656

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

henry-deriv
Copy link
Contributor

@henry-deriv henry-deriv commented Nov 27, 2024

Changes:

Updated quill-icons package version.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 3, 2024 9:16am

Copy link
Contributor

github-actions bot commented Nov 27, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17656](https://github.com/deriv-com/deriv-app/pull/17656)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-henry-deriv-henry-grwt-3242update-qui-631732.binary.sx?qa_server=red.derivws.com&app_id=23813
    - **Original**: https://deriv-app-git-fork-henry-deriv-henry-grwt-3242update-qui-631732.binary.sx
- **App ID**: `23813`

Copy link
Contributor

github-actions bot commented Nov 27, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 41
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-grwt-3242update-qui-631732.binary.sx/

@coveralls
Copy link

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12136095169

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 53.903%

Totals Coverage Status
Change from base Build 12134582390: 0.003%
Covered Lines: 32851
Relevant Lines: 56842

💛 - Coveralls

amam-deriv
amam-deriv previously approved these changes Nov 27, 2024
Copy link
Contributor

@amam-deriv amam-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, would be great if can add summary of the changes, left a suggestion/question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants