Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT]/mayuran/bot-2180/ improve journal messages #17666

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mayuran-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 28, 2024 2:31pm

Copy link
Contributor

github-actions bot commented Nov 27, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17666](https://github.com/deriv-com/deriv-app/pull/17666)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mayuran-deriv-mayuran-fix-improve-jou-b17866.binary.sx?qa_server=red.derivws.com&app_id=24162
    - **Original**: https://deriv-app-git-fork-mayuran-deriv-mayuran-fix-improve-jou-b17866.binary.sx
- **App ID**: `24162`

Copy link
Contributor

github-actions bot commented Nov 27, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-mayuran-deriv-mayuran-fix-improve-jou-b17866.binary.sx/

@coveralls
Copy link

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 12070438195

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 53.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/bot-web-ui/src/stores/run-panel-store.ts 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
packages/bot-web-ui/src/stores/run-panel-store.ts 1 41.39%
Totals Coverage Status
Change from base Build 12068479553: 0.001%
Covered Lines: 32823
Relevant Lines: 56776

💛 - Coveralls

shafin-deriv
shafin-deriv previously approved these changes Nov 28, 2024
vinu-deriv
vinu-deriv previously approved these changes Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants